adamdebreceni commented on a change in pull request #839:
URL: https://github.com/apache/nifi-minifi-cpp/pull/839#discussion_r492756737
##########
File path: libminifi/include/utils/Id.h
##########
@@ -43,107 +44,41 @@ class uuid;
#define UUID_TIME_STR "time"
#define UUID_WINDOWS_STR "windows"
-
namespace org {
namespace apache {
namespace nifi {
namespace minifi {
namespace utils {
-template<typename T, typename C>
-class IdentifierBase {
+class Identifier {
+ friend struct IdentifierTestAccessor;
public:
- IdentifierBase(T myid) { // NOLINT
- copyInto(myid);
- }
-
- IdentifierBase(const IdentifierBase &other) {
- copyInto(other.id_);
- }
-
- IdentifierBase(IdentifierBase &&other)
- : converted_(std::move(other.converted_)) {
- copyInto(other.id_);
- }
-
- IdentifierBase() = default;
-
- IdentifierBase &operator=(const IdentifierBase &other) {
- copyInto(other.id_);
- return *this;
- }
-
- IdentifierBase &operator=(T o) {
- copyInto(o);
- return *this;
- }
+ using Data = std::array<uint8_t, 16>;
- void getIdentifier(T other) const {
- copyOutOf(other);
- }
+ Identifier() = default;
+ explicit Identifier(const Data& data);
+ explicit Identifier(const std::string& data);
Review comment:
removed the `std::string` constructor as it was not really used, but the
`std::string` assignment is more frequently used, and since other PR-s are
modifying those parts IMO we should wait till these things are merged
##########
File path: libminifi/include/utils/FlatMap.h
##########
@@ -0,0 +1,211 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#ifndef LIBMINIFI_INCLUDE_UTILS_FLATMAP_H_
+#define LIBMINIFI_INCLUDE_UTILS_FLATMAP_H_
+
+#include <tuple>
+#include <functional>
+#include <vector>
+#include <utility>
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace utils {
+
+template<typename K, typename V>
+class FlatMap{
+ public:
+ using value_type = std::pair<K, V>;
+
+ private:
+ using Container = std::vector<value_type>;
+
+ public:
+ class iterator{
+ friend class const_iterator;
+ friend class FlatMap;
+ explicit iterator(typename Container::iterator it): it_(it) {}
+
+ public:
+ using difference_type = void;
+ using value_type = FlatMap::value_type;
+ using pointer = void;
+ using reference = void;
+ using iterator_category = void;
Review comment:
done
##########
File path: libminifi/include/utils/FlatMap.h
##########
@@ -0,0 +1,211 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#ifndef LIBMINIFI_INCLUDE_UTILS_FLATMAP_H_
+#define LIBMINIFI_INCLUDE_UTILS_FLATMAP_H_
+
+#include <tuple>
+#include <functional>
+#include <vector>
+#include <utility>
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace utils {
+
+template<typename K, typename V>
+class FlatMap{
+ public:
+ using value_type = std::pair<K, V>;
+
+ private:
+ using Container = std::vector<value_type>;
+
+ public:
+ class iterator{
+ friend class const_iterator;
+ friend class FlatMap;
+ explicit iterator(typename Container::iterator it): it_(it) {}
+
+ public:
+ using difference_type = void;
+ using value_type = FlatMap::value_type;
+ using pointer = void;
+ using reference = void;
+ using iterator_category = void;
+
+ value_type* operator->() const {return &(*it_);}
+ value_type& operator*() const {return *it_;}
+
+ bool operator==(const iterator& other) const {
+ return it_ == other.it_;
+ }
+
+ bool operator!=(const iterator& other) const {
+ return !(*this == other);
+ }
+
+ iterator& operator++() {
+ ++it_;
+ return *this;
+ }
+
+ private:
+ typename Container::iterator it_;
+ };
+
+ class const_iterator{
+ friend class FlatMap;
+ explicit const_iterator(typename Container::const_iterator it): it_(it) {}
+
+ public:
+ const_iterator(iterator it): it_(it.it_) {} // NOLINT
+ using difference_type = void;
+ using value_type = const FlatMap::value_type;
+ using pointer = void;
+ using reference = void;
+ using iterator_category = void;
Review comment:
done
##########
File path: libminifi/include/utils/FlatMap.h
##########
@@ -0,0 +1,211 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#ifndef LIBMINIFI_INCLUDE_UTILS_FLATMAP_H_
+#define LIBMINIFI_INCLUDE_UTILS_FLATMAP_H_
+
+#include <tuple>
+#include <functional>
+#include <vector>
+#include <utility>
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace utils {
+
+template<typename K, typename V>
+class FlatMap{
+ public:
+ using value_type = std::pair<K, V>;
+
+ private:
+ using Container = std::vector<value_type>;
+
+ public:
+ class iterator{
+ friend class const_iterator;
+ friend class FlatMap;
+ explicit iterator(typename Container::iterator it): it_(it) {}
+
+ public:
+ using difference_type = void;
+ using value_type = FlatMap::value_type;
+ using pointer = void;
+ using reference = void;
+ using iterator_category = void;
+
+ value_type* operator->() const {return &(*it_);}
+ value_type& operator*() const {return *it_;}
+
+ bool operator==(const iterator& other) const {
+ return it_ == other.it_;
+ }
+
+ bool operator!=(const iterator& other) const {
+ return !(*this == other);
+ }
+
+ iterator& operator++() {
+ ++it_;
+ return *this;
+ }
+
+ private:
+ typename Container::iterator it_;
+ };
+
+ class const_iterator{
+ friend class FlatMap;
+ explicit const_iterator(typename Container::const_iterator it): it_(it) {}
+
+ public:
+ const_iterator(iterator it): it_(it.it_) {} // NOLINT
+ using difference_type = void;
+ using value_type = const FlatMap::value_type;
+ using pointer = void;
+ using reference = void;
+ using iterator_category = void;
+
+ value_type* operator->() const {return &(*it_);}
+ value_type& operator*() const {return *it_;}
+
+ bool operator==(const const_iterator& other) const {
+ return it_ == other.it_;
+ }
+
+ bool operator!=(const const_iterator& other) const {
+ return !(*this == other);
+ }
+
+ const_iterator& operator++() {
+ ++it_;
+ return *this;
+ }
+
+ private:
+ typename Container::const_iterator it_;
+ };
+
+ FlatMap() = default;
+ FlatMap(const FlatMap&) = default;
+ FlatMap(FlatMap&&) noexcept = default;
+ FlatMap(std::initializer_list<value_type> items) : data_(items) {}
+ template<class InputIterator>
+ FlatMap(InputIterator begin, InputIterator end) : data_(begin, end) {}
+
+ FlatMap& operator=(const FlatMap& source) = default;
+ FlatMap& operator=(FlatMap&& source) = default;
+ FlatMap& operator=(std::initializer_list<value_type> items) {
+ data_ = items;
+ return *this;
+ }
+
+ std::size_t size() {
+ return data_.size();
+ }
+
+ V& operator[](const K& key) {
+ auto it = find(key);
+ if (it != end()) {
+ return it->second;
+ }
+ data_.emplace_back(key, V{});
+ return data_.rbegin()->second;
+ }
+
+ iterator erase(const_iterator pos) {
+ auto offset = pos.it_ - data_.begin();
+ std::swap(*data_.rbegin(), *(data_.begin() + offset));
+ data_.pop_back();
+ return iterator{data_.begin() + offset};
+ }
+
+ std::size_t erase(const K& key) {
+ for (auto it = data_.begin(); it != data_.end(); ++it) {
+ if (it->first == key) {
+ std::swap(*data_.rbegin(), *it);
+ data_.pop_back();
+ return 1;
+ }
+ }
+ return 0;
+ }
+
+ std::pair<iterator, bool> insert(const value_type& value) {
+ auto it = find(value.first);
+ if (it != end()) {
+ return {it, false};
+ }
+ data_.push_back(value);
+ return {iterator{data_.begin() + data_.size() - 1}, true};
+ }
+
+ template<typename M>
+ std::pair<iterator, bool> insert_or_assign(const K& key, M&& value) {
+ auto it = find(key);
+ if (it != end()) {
+ it->second = std::forward<M>(value);
+ return {it, false};
+ }
+ data_.emplace_back(key, std::forward<M>(value));
+ return {iterator{data_.begin() + data_.size() - 1}, true};
+ }
+
+ iterator find(const K& key) {
+ for (auto it = data_.begin(); it != data_.end(); ++it) {
+ if (it->first == key) return iterator{it};
+ }
+ return end();
+ }
+
+ const_iterator find(const K& key) const {
+ for (auto it = data_.begin(); it != data_.end(); ++it) {
+ if (it->first == key) return const_iterator{it};
+ }
+ return end();
+ }
+
+ iterator begin() {
+ return iterator{data_.begin()};
+ }
+
+ iterator end() {
+ return iterator{data_.end()};
+ }
+
+ const_iterator begin() const {
+ return const_iterator{data_.begin()};
+ }
+
+ const_iterator end() const {
+ return const_iterator{data_.end()};
+ }
Review comment:
done
##########
File path: libminifi/src/core/FlowFile.cpp
##########
@@ -43,16 +45,13 @@ FlowFile::FlowFile()
event_time_(0),
claim_(nullptr),
marked_delete_(false),
- connection_(nullptr),
- original_connection_() {
+ connection_() {
Review comment:
removed
##########
File path: libminifi/src/FlowFileRecord.cpp
##########
@@ -261,88 +144,104 @@ bool FlowFileRecord::Serialize() {
return false;
}
- if (flow_repository_->Put(uuidStr_,
const_cast<uint8_t*>(outStream.getBuffer()), outStream.getSize())) {
- logger_->log_debug("NiFi FlowFile Store event %s size %llu success",
uuidStr_, outStream.getSize());
+ if (flowRepository->Put(getUUIDStr(),
const_cast<uint8_t*>(outStream.getBuffer()), outStream.getSize())) {
+ logger_->log_debug("NiFi FlowFile Store event %s size " "%" PRIu64 "
success", getUUIDStr(), outStream.getSize());
// on behalf of the persisted record instance
if (claim_) claim_->increaseFlowFileRecordOwnedCount();
return true;
} else {
- logger_->log_error("NiFi FlowFile Store event %s size %llu fail",
uuidStr_, outStream.getSize());
+ logger_->log_error("NiFi FlowFile Store failed %s size " "%" PRIu64 "
fail", getUUIDStr(), outStream.getSize());
Review comment:
removed
##########
File path: libminifi/include/utils/FlatMap.h
##########
@@ -0,0 +1,211 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#ifndef LIBMINIFI_INCLUDE_UTILS_FLATMAP_H_
+#define LIBMINIFI_INCLUDE_UTILS_FLATMAP_H_
+
+#include <tuple>
+#include <functional>
+#include <vector>
+#include <utility>
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace utils {
+
+template<typename K, typename V>
+class FlatMap{
+ public:
+ using value_type = std::pair<K, V>;
+
+ private:
+ using Container = std::vector<value_type>;
+
+ public:
+ class iterator{
+ friend class const_iterator;
+ friend class FlatMap;
+ explicit iterator(typename Container::iterator it): it_(it) {}
+
+ public:
+ using difference_type = void;
+ using value_type = FlatMap::value_type;
+ using pointer = void;
+ using reference = void;
+ using iterator_category = void;
+
+ value_type* operator->() const {return &(*it_);}
+ value_type& operator*() const {return *it_;}
+
+ bool operator==(const iterator& other) const {
+ return it_ == other.it_;
+ }
+
+ bool operator!=(const iterator& other) const {
+ return !(*this == other);
+ }
+
+ iterator& operator++() {
+ ++it_;
+ return *this;
+ }
+
+ private:
+ typename Container::iterator it_;
+ };
+
+ class const_iterator{
+ friend class FlatMap;
+ explicit const_iterator(typename Container::const_iterator it): it_(it) {}
+
+ public:
+ const_iterator(iterator it): it_(it.it_) {} // NOLINT
Review comment:
added
##########
File path: libminifi/include/utils/FlatMap.h
##########
@@ -0,0 +1,211 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#ifndef LIBMINIFI_INCLUDE_UTILS_FLATMAP_H_
+#define LIBMINIFI_INCLUDE_UTILS_FLATMAP_H_
+
+#include <tuple>
+#include <functional>
+#include <vector>
+#include <utility>
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace utils {
+
+template<typename K, typename V>
+class FlatMap{
+ public:
+ using value_type = std::pair<K, V>;
+
+ private:
+ using Container = std::vector<value_type>;
+
+ public:
+ class iterator{
+ friend class const_iterator;
+ friend class FlatMap;
+ explicit iterator(typename Container::iterator it): it_(it) {}
+
+ public:
+ using difference_type = void;
+ using value_type = FlatMap::value_type;
+ using pointer = void;
+ using reference = void;
+ using iterator_category = void;
+
+ value_type* operator->() const {return &(*it_);}
+ value_type& operator*() const {return *it_;}
+
+ bool operator==(const iterator& other) const {
+ return it_ == other.it_;
+ }
+
+ bool operator!=(const iterator& other) const {
+ return !(*this == other);
+ }
+
+ iterator& operator++() {
+ ++it_;
+ return *this;
+ }
+
+ private:
+ typename Container::iterator it_;
+ };
+
+ class const_iterator{
+ friend class FlatMap;
+ explicit const_iterator(typename Container::const_iterator it): it_(it) {}
+
+ public:
+ const_iterator(iterator it): it_(it.it_) {} // NOLINT
+ using difference_type = void;
+ using value_type = const FlatMap::value_type;
+ using pointer = void;
+ using reference = void;
+ using iterator_category = void;
+
+ value_type* operator->() const {return &(*it_);}
+ value_type& operator*() const {return *it_;}
+
+ bool operator==(const const_iterator& other) const {
+ return it_ == other.it_;
+ }
+
+ bool operator!=(const const_iterator& other) const {
+ return !(*this == other);
+ }
+
+ const_iterator& operator++() {
+ ++it_;
+ return *this;
+ }
+
+ private:
+ typename Container::const_iterator it_;
+ };
+
+ FlatMap() = default;
+ FlatMap(const FlatMap&) = default;
+ FlatMap(FlatMap&&) noexcept = default;
+ FlatMap(std::initializer_list<value_type> items) : data_(items) {}
+ template<class InputIterator>
+ FlatMap(InputIterator begin, InputIterator end) : data_(begin, end) {}
+
+ FlatMap& operator=(const FlatMap& source) = default;
+ FlatMap& operator=(FlatMap&& source) = default;
+ FlatMap& operator=(std::initializer_list<value_type> items) {
+ data_ = items;
+ return *this;
+ }
+
+ std::size_t size() {
+ return data_.size();
+ }
+
+ V& operator[](const K& key) {
+ auto it = find(key);
+ if (it != end()) {
+ return it->second;
+ }
+ data_.emplace_back(key, V{});
+ return data_.rbegin()->second;
+ }
+
+ iterator erase(const_iterator pos) {
+ auto offset = pos.it_ - data_.begin();
+ std::swap(*data_.rbegin(), *(data_.begin() + offset));
+ data_.pop_back();
+ return iterator{data_.begin() + offset};
+ }
+
+ std::size_t erase(const K& key) {
+ for (auto it = data_.begin(); it != data_.end(); ++it) {
+ if (it->first == key) {
+ std::swap(*data_.rbegin(), *it);
+ data_.pop_back();
+ return 1;
+ }
+ }
+ return 0;
+ }
+
+ std::pair<iterator, bool> insert(const value_type& value) {
+ auto it = find(value.first);
+ if (it != end()) {
+ return {it, false};
+ }
+ data_.push_back(value);
+ return {iterator{data_.begin() + data_.size() - 1}, true};
+ }
+
+ template<typename M>
+ std::pair<iterator, bool> insert_or_assign(const K& key, M&& value) {
+ auto it = find(key);
+ if (it != end()) {
+ it->second = std::forward<M>(value);
+ return {it, false};
+ }
+ data_.emplace_back(key, std::forward<M>(value));
+ return {iterator{data_.begin() + data_.size() - 1}, true};
+ }
+
+ iterator find(const K& key) {
+ for (auto it = data_.begin(); it != data_.end(); ++it) {
+ if (it->first == key) return iterator{it};
+ }
+ return end();
+ }
+
+ const_iterator find(const K& key) const {
+ for (auto it = data_.begin(); it != data_.end(); ++it) {
+ if (it->first == key) return const_iterator{it};
+ }
+ return end();
+ }
+
+ iterator begin() {
+ return iterator{data_.begin()};
+ }
+
+ iterator end() {
+ return iterator{data_.end()};
+ }
+
+ const_iterator begin() const {
Review comment:
added
##########
File path: libminifi/src/core/ProcessSession.cpp
##########
@@ -144,41 +120,34 @@ std::shared_ptr<core::FlowFile>
ProcessSession::clone(const std::shared_ptr<core
}
std::shared_ptr<core::FlowFile>
ProcessSession::cloneDuringTransfer(std::shared_ptr<core::FlowFile> &parent) {
- std::map<std::string, std::string> empty;
- std::shared_ptr<core::FlowFile> record =
std::make_shared<FlowFileRecord>(process_context_->getFlowFileRepository(),
process_context_->getContentRepository(), empty);
+ auto record = std::make_shared<FlowFileRecord>();
- if (record) {
- auto flow_version =
process_context_->getProcessorNode()->getFlowIdentifier();
- if (flow_version != nullptr) {
- auto flow_id = flow_version->getFlowId();
- std::string attr = FlowAttributeKey(FLOW_ID);
- record->setAttribute(attr, flow_version->getFlowId());
- }
- this->_clonedFlowFiles[record->getUUIDStr()] = record;
- logger_->log_debug("Clone FlowFile with UUID %s during transfer",
record->getUUIDStr());
- // Copy attributes
- std::map<std::string, std::string> parentAttributes =
parent->getAttributes();
- std::map<std::string, std::string>::iterator it;
- for (it = parentAttributes.begin(); it != parentAttributes.end(); it++) {
- if (it->first == FlowAttributeKey(ALTERNATE_IDENTIFIER) || it->first ==
FlowAttributeKey(DISCARD_REASON) || it->first == FlowAttributeKey(UUID))
- // Do not copy special attributes from parent
- continue;
- record->setAttribute(it->first, it->second);
- }
- record->setLineageStartDate(parent->getlineageStartDate());
-
- record->setLineageIdentifiers(parent->getlineageIdentifiers());
- record->getlineageIdentifiers().insert(parent->getUUIDStr());
-
- // Copy Resource Claim
- std::shared_ptr<ResourceClaim> parent_claim = parent->getResourceClaim();
- record->setResourceClaim(parent_claim);
- if (parent_claim) {
- record->setOffset(parent->getOffset());
- record->setSize(parent->getSize());
- }
- provenance_report_->clone(parent, record);
+ auto flow_version =
process_context_->getProcessorNode()->getFlowIdentifier();
+ if (flow_version != nullptr) {
+ record->setAttribute(SpecialFlowAttribute::FLOW_ID,
flow_version->getFlowId());
+ }
+ this->_clonedFlowFiles[record->getUUIDStr()] = record;
+ logger_->log_debug("Clone FlowFile with UUID %s during transfer",
record->getUUIDStr());
+ // Copy attributes
+ for (const auto& attribute : parent->getAttributes()) {
+ if (attribute.first == SpecialFlowAttribute::ALTERNATE_IDENTIFIER ||
attribute.first == SpecialFlowAttribute::DISCARD_REASON || attribute.first ==
SpecialFlowAttribute::UUID) {
Review comment:
done
##########
File path: libminifi/test/Utils.h
##########
@@ -0,0 +1,38 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#ifndef LIBMINIFI_TEST_UTILS_H_
+#define LIBMINIFI_TEST_UTILS_H_
+
+#define FIELD_ACCESSOR(ClassName, field) \
Review comment:
more like poor man's code generator
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
