arpadboda commented on a change in pull request #875:
URL: https://github.com/apache/nifi-minifi-cpp/pull/875#discussion_r497600016
##########
File path: libminifi/include/properties/Properties.h
##########
@@ -82,6 +84,16 @@ class Properties {
*/
int getInt(const std::string &key, int default_value) const;
+ utils::optional<std::string> get(const std::string& key) const {
+ std::string result;
+ const bool found = get(key, result);
Review comment:
Just fancy, for me this is the case when ternary operator simplifies the
code:
```
return get(key, result) ? result : utils::nullopt;
```
Feel free to ignore in case you doesn't share this opinion.
##########
File path: libminifi/include/utils/IntervalSwitch.h
##########
@@ -0,0 +1,80 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#pragma once
+
+#include <functional>
+#include <utility>
+
+#include "utils/gsl.h"
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace utils {
+
+enum class IntervalSwitchState {
+ LOWER,
+ UPPER,
+};
+
+namespace detail {
+struct SwitchReturn {
+ IntervalSwitchState state;
+ bool switched;
+};
+} // namespace detail
+
+template<typename T, typename Comp = std::less<T>>
+class IntervalSwitch {
+ public:
+ IntervalSwitch(T lower_threshold, T upper_threshold, const
IntervalSwitchState initial_state = IntervalSwitchState::UPPER)
+ :lower_threshold_{std::move(lower_threshold)},
upper_threshold_{std::move(upper_threshold)}, state_{initial_state} {
+ gsl_Expects(!less_(upper_threshold_, lower_threshold_));
+ }
+
+ detail::SwitchReturn operator()(const T& value) {
Review comment:
This seems a bit overcomplicated to be with multiple local members and
return.
Suggestion:
```
const auto old_state = state_;
if (less_(value, lower_threshold_)) {
state_ = IntervalSwitchState::LOWER;
} else if (!less_(value, upper_threshold_)) {
state_ = IntervalSwitchState::UPPER;
}
return {state_, state_ != old_state};
```
Az the "else if" branch was actually doing nothing, inverting the condition
could help removing it completely.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
