adamdebreceni commented on a change in pull request #917:
URL: https://github.com/apache/nifi-minifi-cpp/pull/917#discussion_r498163298
##########
File path: extensions/libarchive/CompressContent.cpp
##########
@@ -171,7 +183,7 @@ void CompressContent::onTrigger(const
std::shared_ptr<core::ProcessContext> &con
std::shared_ptr<core::FlowFile> processFlowFile = session->create(flowFile);
bool success = false;
if (encapsulateInTar_) {
- CompressContent::WriteCallback callback(compressMode_, compressLevel_,
compressFormat, flowFile, session);
+ CompressContent::WriteCallback callback(compressMode_, compressLevel_,
toString(compressFormat), flowFile, session);
Review comment:
we should forward the enum itself instead of its string representation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
