jfrazee commented on pull request #4460: URL: https://github.com/apache/nifi/pull/4460#issuecomment-702386711
@MikeThomsen I'm going to nit on something. This being called `JAVA_VERSION` would make me think it'd be something like 11 or 1.8 or one of the many openjdk tags and not the base image name. That brings up another question. What's the tradeoff between having the base image be completely specified vs. just a tag for the openjdk image? My thinking is: 1. If it was just the tag for openjdk it's more likely the image will be as expected (since most but not all of the openjdk tags are Debian based). 2. Whereas allowing the entire base image to be changed would let people use the released source to build images of their own, let's say hardened or approved images, with the drawback of it not working if they provide a non-Debian based image. (That said, it's very light on Debian assumptions, so there might be even some room for some easy changes to make it work with other distros later.) I think (2) is reasonable motivation. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
