adamdebreceni commented on a change in pull request #915:
URL: https://github.com/apache/nifi-minifi-cpp/pull/915#discussion_r498754719
##########
File path: extensions/aws/AWSLoader.h
##########
@@ -16,43 +16,48 @@
* limitations under the License.
*/
-#ifndef NIFI_MINIFI_CPP_AWSLOADER_H
-#define NIFI_MINIFI_CPP_AWSLOADER_H
+#pragma once
+
+#include <vector>
+#include <string>
+#include <memory>
#include "core/ClassLoader.h"
#include "utils/StringUtils.h"
#include "controllerservices/AWSCredentialsService.h"
+#include "processors/PutS3Object.h"
class AWSObjectFactory : public core::ObjectFactory {
-
public:
AWSObjectFactory() = default;
/**
* Gets the name of the object.
* @return class name of processor
*/
- virtual std::string getName() override{
+ std::string getName() override {
return "AWSObjectFactory";
}
- virtual std::string getClassName() override{
+ std::string getClassName() override {
return "AWSObjectFactory";
}
/**
* Gets the class name for the object
* @return class name for the processor.
*/
- virtual std::vector<std::string> getClassNames() override{
+ std::vector<std::string> getClassNames() override {
std::vector<std::string> class_names;
class_names.push_back("AWSCredentialsService");
Review comment:
don't we need to add `PutS3Object` to the `class_names` vector as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
