szaszm commented on a change in pull request #900:
URL: https://github.com/apache/nifi-minifi-cpp/pull/900#discussion_r502345911
##########
File path: extensions/libarchive/MergeContent.h
##########
@@ -138,67 +107,87 @@ class BinaryConcatenationMerge : public MergeBin {
return ret;
}
};
+
+ private:
+ std::string header_;
+ std::string footer_;
+ std::string demarcator_;
};
// Archive Class
class ArchiveMerge {
-public:
- // Nest Callback Class for read stream
- class ReadCallback: public InputStreamCallback {
+ public:
+ class ArchiveWriter : public io::OutputStream {
Review comment:
The indentation went off by one space on this line.
```suggestion
class ArchiveWriter : public io::OutputStream {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
