szaszm commented on a change in pull request #921: URL: https://github.com/apache/nifi-minifi-cpp/pull/921#discussion_r503848631
########## File path: extensions/civetweb/processors/ListenHTTP.cpp ########## @@ -368,7 +368,7 @@ bool ListenHTTP::Handler::handlePost(CivetServer *server, struct mg_connection * // Always send 100 Continue, as allowed per standard to minimize client delay (https://www.w3.org/Protocols/rfc2616/rfc2616-sec8.html) mg_printf(conn, "HTTP/1.1 100 Continue\r\n\r\n"); - return enqueueRequest(conn, req_info, createContentBuffer(conn, req_info)); + return enqueueRequest(conn, req_info, std::move(createContentBuffer(conn, req_info))); Review comment: No need to cast an rvalue to an rvalue reference, i.e. call `std::move` on an rvalue. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
