[ 
https://issues.apache.org/jira/browse/NIFI-2809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15540753#comment-15540753
 ] 

James Wing commented on NIFI-2809:
----------------------------------

[~frankmarit], Thanks for putting this together, it will be great to hook NiFi 
up with Google cloud.  I took a quick look at the patch contents, and I have a 
couple questions for you:

*Bundles*
After applying the patch, I found two NAR bundles:

nifi-nar-bundles/nifi-gcp-bundle/
nifi-nar-bundles/nifi-gcs-bundle/
        
But the contents of both look very similar to me.  Is this intended?

*Licensing*
Have you taken a look at licensing?  I believe this is the first contribution 
using Google Cloud Platform, so NiFi does not yet include the relevant 
licensing info.  Good news, it looks like Google's client SDK is available 
under an Apache 2.0 license.  We need to make sure we record this in 
{{nifi-assembly/NOTICE}} similar to other ASLv2 dependencies, with something 
like the following:

{code}
  (ASLv2) Google APIs Client Library for Java 1.21.0
    The following NOTICE information applies:
      Copyright (c) 2013 Google Inc.
{code}
I'm not sure that is all we need, but I believe we need at least that much.

> Add processors for Google Cloud Storage Fetch/Put/Delete
> --------------------------------------------------------
>
>                 Key: NIFI-2809
>                 URL: https://issues.apache.org/jira/browse/NIFI-2809
>             Project: Apache NiFi
>          Issue Type: New Feature
>    Affects Versions: 1.1.0
>            Reporter: Frank Maritato
>         Attachments: gcs_bundle.patch
>
>
> Creating a ticket to add nifi processors for Google Cloud Storage similar to 
> how the AWS S3 processors are done:
> * FetchGCSObject
> * PutGCSObject
> * DeleteGCSObject
> I have the code mostly written and will attach the patch file when complete.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to