fgerlits commented on a change in pull request #925:
URL: https://github.com/apache/nifi-minifi-cpp/pull/925#discussion_r507599295
##########
File path: .github/workflows/ci.yml
##########
@@ -13,12 +13,11 @@ jobs:
- id: setup_env
run: |
echo -e "127.0.0.1\t$HOSTNAME" | sudo tee -a /etc/hosts > /dev/null
- echo "::set-env name=CMAKE_BUILD_OPTIONS::-DENABLE_PCAP=TRUE
-DENABLE_LUA_SCRIPTING=1"
- sudo xcode-select -switch /Applications/Xcode_10.3.app
+ sudo xcode-select -switch /Applications/Xcode_11.2.1.app
- id: build
- run: ./bootstrap.sh -e -t && cd build && cmake
-DCMAKE_BUILD_TYPE=Release -DCMAKE_VERBOSE_MAKEFILE=ON
-DCMAKE_RULE_MESSAGES=OFF -DSTRICT_GSL_CHECKS=AUDIT .. && cmake --build .
--parallel 4 && make test ARGS="--timeout 300 -j4 --output-on-failure" && make
linter
- macos_xcode_11_2_1:
- name: "macos-xcode11.2.1"
+ run: ./bootstrap.sh -e -t && cd build && cmake
-DCMAKE_BUILD_TYPE=Release -DENABLE_LUA_SCRIPTING=1 -DCMAKE_VERBOSE_MAKEFILE=ON
-DCMAKE_RULE_MESSAGES=OFF -DSTRICT_GSL_CHECKS=AUDIT .. && cmake --build .
--parallel 4 && make test ARGS="--timeout 300 -j4 --output-on-failure" && make
linter
+ macos_xcode_11_7:
+ name: "macos-xcode12.0"
Review comment:
Oops, good catch. Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
