adamdebreceni commented on a change in pull request #920:
URL: https://github.com/apache/nifi-minifi-cpp/pull/920#discussion_r508484578
##########
File path: extensions/standard-processors/tests/unit/TailFileTests.cpp
##########
@@ -1129,8 +1129,11 @@ TEST_CASE("TailFile finds and finishes the renamed file
and continues with the n
utils::Identifier tail_file_uuid =
utils::IdGenerator::getIdGenerator()->generate();
const core::Relationship success_relationship{"success", "everything is
fine"};
+ // use persistent state storage that defaults to rocksDB, not volatile
+ const auto configuration = std::make_shared<minifi::Configure>();
Review comment:
is this necessary? `TestController::createPlan` default constructs a
`Configure` object if `nullptr` is provided, and by default a
`RocksDbPersistableKeyValueStoreService` is constructed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
