lordgamez commented on a change in pull request #929:
URL: https://github.com/apache/nifi-minifi-cpp/pull/929#discussion_r509934214
##########
File path: libminifi/test/pcap-tests/PcapTest.cpp
##########
@@ -69,9 +69,10 @@ class PcapTestHarness : public IntegrationBase {
void runAssertions() {
using org::apache::nifi::minifi::utils::verifyLogLinePresenceInPollTime;
assert(verifyLogLinePresenceInPollTime(std::chrono::milliseconds(wait_time_),
- "Starting capture",
- "Stopping capture",
- "Stopped device capture. clearing queues",
+ // These assertions don't work, but the test is still useful to check
that the processor starts
Review comment:
Maybe we could add a TODO or a FIXME message here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
