markap14 commented on pull request #4602:
URL: https://github.com/apache/nifi/pull/4602#issuecomment-717443793
Thanks for reviewing @tpalfy and @exceptionfactory.
@exceptionfactory I don't think we can really unit test this. I mean, we
could write a test that verifies that if connected to a cluster, that
`controller.onClusterDisconnect()` gets called. But it's pretty clear that it
does given the code snippet:
```
if (controller.isConnected()) {
controller.onClusterDisconnect();
}
```
I don't think an integration test would really be any more help. A
system-level test could potentially be written. I may consider that as a
follow-on. But given that it's easy to verify the fix manually and @tpalfy and
I have, I don't think it's worth holding up the PR for that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
