adamdebreceni commented on a change in pull request #932:
URL: https://github.com/apache/nifi-minifi-cpp/pull/932#discussion_r513383015
##########
File path: libminifi/include/utils/SmallString.h
##########
@@ -34,6 +34,10 @@ class SmallString : public std::array<char, N + 1> {
return {c_str()};
}
+ size_t length() const noexcept {
Review comment:
I intended to mimic the signature of `std::string::length` on purpose,
to make it as similar as possible, and that is only `constexpr` from `c++20`,
should I change it to `constexpr`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
