bbende commented on pull request #4512:
URL: https://github.com/apache/nifi/pull/4512#issuecomment-721359149
Thanks, latest updates look good. I noticed one minor issue with the
dependency setup for the "Schema Branch" and "Schema Version" properties, the
PR has them set to depend on the two HWX strategies, but really they go with
the "Schema Name" strategy. I'm going to include a small commit that corrects
that, the diff looks like this...
```+++
b/nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-avro-record-utils/src/main/java/org/apache/nifi/schema/access/SchemaAccessUtils.java
@@ -88,7 +88,7 @@ public class SchemaAccessUtils {
"If the chosen Schema Registry does not support
branching, this value will be ignored.")
.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
- .dependsOn(SCHEMA_ACCESS_STRATEGY, HWX_SCHEMA_REF_ATTRIBUTES,
HWX_CONTENT_ENCODED_SCHEMA)
+ .dependsOn(SCHEMA_ACCESS_STRATEGY, SCHEMA_NAME_PROPERTY)
.required(false)
.build();
@@ -99,7 +99,7 @@ public class SchemaAccessUtils {
"If not specified then the latest version of the schema
will be retrieved.")
.addValidator(StandardValidators.POSITIVE_INTEGER_VALIDATOR)
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
- .dependsOn(SCHEMA_ACCESS_STRATEGY, HWX_SCHEMA_REF_ATTRIBUTES,
HWX_CONTENT_ENCODED_SCHEMA)
+ .dependsOn(SCHEMA_ACCESS_STRATEGY, SCHEMA_NAME_PROPERTY)
.required(false)
.build();
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
