ChrisSamo632 commented on a change in pull request #4153:
URL: https://github.com/apache/nifi/pull/4153#discussion_r523807890
##########
File path:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/FetchElasticsearchHttp.java
##########
@@ -120,11 +121,11 @@
public static final PropertyDescriptor TYPE = new
PropertyDescriptor.Builder()
.name("fetch-es-type")
.displayName("Type")
- .description("The (optional) type of this document, used by
Elasticsearch for indexing and searching. If the property is empty, "
- + "the first document matching the identifier across all
types will be retrieved.")
- .required(false)
+ .description("The type of this document (if empty, the first
document matching the identifier across all types will be retrieved). "
+ + "This must be empty (check 'Set empty string') or '_doc'
for Elasticsearch 7.0+.")
+ .required(true)
Review comment:
I agree this should be optional everywhere and a sensible (cross-ES
version) operation/value provided where this is unset, e.g. omit _type from
bulk operations, no effect for queries, use `_all` for GET (Fetch) for backward
compatability (users using ES 7+ will need to set this to an appropriate value,
e.g. `_doc`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
