ChrisSamo632 opened a new pull request #4667:
URL: https://github.com/apache/nifi/pull/4667
#### Description of PR
Continuation of PR #4153 (which appears to have stalled) by @gresockj.
Addressed (@ijokarumawak & @MikeThomsen) comments from the above PR and:
* NIFI-6403 - made TYPE optional on all Elasticsearch HTTP/Record processors
* default `_type` to `_all` for Fetch processor where TYPE property is
unset/blank
* note that using `_type` is still possible in ES 6 & 7, but deprecated
and discouraged; the expectation is that trying to use `_type` as of ES 8+ will
not be possible, so some processors might then be unusable
* decided to take the approach that Elasticsearch should apply its own
version-specific logic and not to try and replicate parts of that within NiFi
(this is the main difference between this PR and the original one linked above)
* NIFI-6404 - use `_source` query string parameter instead of
`_source_include(s)` as it's compatible between ES <6 and 6+
Commits:
1. Original PR content from #4153 re-based against `main`
2. Changes to address comments (and see below)
Templates for integration tests added to Jira ticket.
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `main`)?
- [x] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [x] Have you verified that the full build is successful on JDK 11?
- [ ] ~~If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?~~
- [ ] ~~If applicable, have you updated the `LICENSE` file, including the
main `LICENSE` file under `nifi-assembly`?~~
- [ ] ~~If applicable, have you updated the `NOTICE` file, including the
main `NOTICE` file found under `nifi-assembly`?~~
- [ ] ~~If adding new Properties, have you added `.displayName` in addition
to .name (programmatic access) for each of the new properties?~~
### For documentation related changes:
- [ ] ~~Have you ensured that format looks appropriate for the output in
which it is rendered?~~
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for
build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
