ottobackwards commented on a change in pull request #4656:
URL: https://github.com/apache/nifi/pull/4656#discussion_r525355265
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ParameterContextResource.java
##########
@@ -400,11 +400,14 @@ public Response submitParameterContextUpdate(
}
private void validateParameterNames(final ParameterContextDTO
parameterContextDto) {
- for (final ParameterEntity entity :
parameterContextDto.getParameters()) {
- final String parameterName = entity.getParameter().getName();
- if (!isLegalParameterName(parameterName)) {
- throw new IllegalArgumentException("Request contains an
illegal Parameter Name (" + parameterName + "). Parameter names may only
include letters, numbers, spaces, and the special " +
- "characters .-_");
+ if (parameterContextDto.getParameters() != null) {
Review comment:
I don't know enough about the api. It doesn't seem that there is a
check that there _are_ parameters at all elsewhere.
Who is the sme?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
