adamdebreceni commented on a change in pull request #938:
URL: https://github.com/apache/nifi-minifi-cpp/pull/938#discussion_r525899629
##########
File path: extensions/sftp/client/SFTPClient.h
##########
@@ -49,6 +50,12 @@ enum class SFTPError : uint8_t {
SFTP_ERROR_UNEXPECTED
};
+struct SFTPException : Exception {
+ explicit SFTPException(const SFTPError err)
+ :Exception{ExceptionType::FILE_OPERATION_EXCEPTION, fmt::format("SFTP
Error {0}", static_cast<int>(err))}
Review comment:
yes, the implicit convertibility is indeed troublesome (and the extra
scope specifier we save when accessing an instance might not be worth it),
although in this specific case I would have gone with changing the parameter
type from `const SFTPError&` to `SFTPError::Type`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
