fgerlits commented on a change in pull request #937:
URL: https://github.com/apache/nifi-minifi-cpp/pull/937#discussion_r527614090
##########
File path: libminifi/include/utils/file/PathUtils.h
##########
@@ -17,12 +17,20 @@
#ifndef LIBMINIFI_INCLUDE_UTILS_FILE_PATHUTILS_H_
#define LIBMINIFI_INCLUDE_UTILS_FILE_PATHUTILS_H_
+#include <climits>
#include <cctype>
#include <cinttypes>
#include <memory>
#include <string>
#include <system_error>
#include <utility>
+#include "utils/OptionalUtils.h"
+
+#ifdef _MSC_VER
Review comment:
I think what's going on is that the constant is `PATH_MAX` on Linux but
`MAX_PATH` on Windows. I don't know why (or if) `canonicalize()` works on
Windows now, but it would probably be better to change the constant on line 70
to `MAX_PATH`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
