adamdebreceni commented on a change in pull request #937:
URL: https://github.com/apache/nifi-minifi-cpp/pull/937#discussion_r529553417



##########
File path: libminifi/include/utils/StringView.h
##########
@@ -0,0 +1,151 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#pragma once
+
+#include <string>
+#include <iterator>
+#include <algorithm>
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace utils {
+
+class StringView {

Review comment:
       as a general rule of thumb, I favour granularity, I believe we should 
promise as little as possible (because promises have to be kept and that takes 
effort), and features should be added on a as-needed basis, for example the 
lack of `operator[]` in this case makes this implementation non-conformant, but 
that is inconsequential
   
   (now on the other hand the added methods `startsWith` and `endsWith` (coming 
in `c++20`) could have pose a problem when "upgrading" to `std::string_view`, 
this is a shortcoming of the language offering no extension methods, that is 
why I believe the best course of action is to centralize the introduction of 
stl parts, so we may use whatever implementation we want, so instead of 
`std::vector` we use `minifi::std::vector`, but of course this decision better 
be made at the beginning of a project)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to