lordgamez opened a new pull request #942:
URL: https://github.com/apache/nifi-minifi-cpp/pull/942
There are multiple changes done in this PR:
- Fixed Boost library usage, as previously even if libboost was present on
the system it was not used. Now if `EXCLUDE_BOOST` is not defined and libboost
is present on the system, it will be used marked with the `USE_BOOST`
definition.
- Tests with Boost usage moved from gcc-4.8 environment to ubuntu 20.04 as
gcc-4.8 seems to be incompatible with Ubuntu 16.04 distribution's Boost
library, causing segfaults and throwing std::bad_alloc exceptions.
- `Permissions` and `Directory Permissions` properties added to `Putfile`
processor for non-Windows systems for changing the permissions of the newly
created output directories and the output file.
- Default permissions for created directories are now `777 & umask` instead
of the previous `700` to be in sync with the boost implementation of
`boost::filesystem::create_directory`.
- Fixed permission problems using the new properties in docker tests.
- Some additional filesystem functionalities are now supported by boost
implementations.
---------------------------------------
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI
results for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
