ChrisSamo632 opened a new pull request #4693:
URL: https://github.com/apache/nifi/pull/4693
…Client Service processors; NIFI-8003 UpdateByQueryElasticsearchProcessor;
addressed various warnings and inefficiencies found in existing processor code
#### Description of PR
NIFI-8001 Dynamic Properties can be used to specify request (query string)
parameters through ElasticsearchClientService processors (e.g.
PutElasticsearchRecord)
NIFI-8003 UpdateByQueryElasticsearch (based on existing
DeleteByQueryElasticsearch) processor
Addressed several warnings/inefficiencies within the existing
processor/service implementations and fixed previously broken ES Integration
tests (maven-failsafe-plugin 3-M5 doesn't currently work for these tests due to
a classpath loading issue expected to be fixed in the upcoming -M6, so reverted
to -M3 for the time being; also some of the integration tests didn't work when
run together as one test would change the data that a subsequent test expected
to be in its original state).
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `main`)?
- [x] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [x] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [x] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for
build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
