[ 
https://issues.apache.org/jira/browse/NIFI-2774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15546664#comment-15546664
 ] 

ASF GitHub Bot commented on NIFI-2774:
--------------------------------------

Github user mosermw commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1036#discussion_r81854062
  
    --- Diff: 
nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/processors/ConsumeJMS.java
 ---
    @@ -54,8 +61,31 @@
     @SeeAlso(value = { PublishJMS.class, JMSConnectionFactoryProvider.class })
     public class ConsumeJMS extends AbstractJMSProcessor<JMSConsumer> {
     
    +    static final AllowableValue AUTO_ACK = new 
AllowableValue(String.valueOf(Session.AUTO_ACKNOWLEDGE),
    --- End diff --
    
    It's a bit confusing to see "Default value: 2" when I hover over the 
tooltip for the Acknowledgement Mode property.  It looks like the serialized 
values will be "1", "2", or "3".  Perhaps this is more of a problem in the UI 
rather than AllowableValue definition.


> ConsumeJMS processor losses messages on NiFi restart
> ----------------------------------------------------
>
>                 Key: NIFI-2774
>                 URL: https://issues.apache.org/jira/browse/NIFI-2774
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>    Affects Versions: 1.0.0, 0.7.0
>            Reporter: Christopher McDermott
>            Assignee: Oleg Zhurakousky
>            Priority: Critical
>             Fix For: 1.1.0, 0.8.0
>
>         Attachments: 2774.patch
>
>
> ConsumeJMS processor uses auto-acknowledge mode.  Unlike the deprecated 
> GetJMSQueue processor it does not provide a way to specify a different ACK 
> mode (i.e. client-acknowledge.)  Using auto-acknowledge, acknowledges message 
> receipt from JMS *before* the messages are actually added to the flow.  This 
> leads to data-loss on NiFi stop (or crash.)
> I believe the fix for this is to allow the user to specify the ACK mode in 
> the processor configuration like is allowed by the GetJMSQueue processor.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to