lordgamez commented on a change in pull request #950:
URL: https://github.com/apache/nifi-minifi-cpp/pull/950#discussion_r536175275
##########
File path: cmake/BundledCivetWeb.cmake
##########
@@ -30,8 +30,8 @@ function(use_bundled_civetweb SOURCE_DIR BINARY_DIR)
endif()
set(BYPRODUCTS
- "lib/${PREFIX}civetweb.${SUFFIX}"
- "lib/${PREFIX}civetweb-cpp.${SUFFIX}"
+ "${CMAKE_INSTALL_LIBDIR}/${PREFIX}civetweb.${SUFFIX}"
Review comment:
[GNUInstallDirs](https://cmake.org/cmake/help/v3.0/module/GNUInstallDirs.html)
should be included to use CMAKE_INSTALL_* variables on unix systems and
CMAKE_INSTALL_LIBDIR should be set explicitly on Windows.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
