mtien-apache commented on pull request #4673: URL: https://github.com/apache/nifi/pull/4673#issuecomment-741499574
+1 LGTM. I ran a full build and ran each test class that was changed with: - JDK 8u231 - AdoptOpenJDK 8 Update 275 - JDK 11.0.5 I debugged through`TlsPlatform` and verified it gets the correct TLS protocols during runtime according to the Java versions. I also verified the tests were able to build when disabling legacy TLS protocols of TLSv1 and TLSv1.1 by configuring the `java.security` file. Thank you. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
