[
https://issues.apache.org/jira/browse/MINIFICPP-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ferenc Gerlits updated MINIFICPP-1432:
--------------------------------------
Description:
The throughput of {{NetworkPrioritizerService}} depends on timing, as a certain
number of tokens are added to the "token bucket" every millisecond, and
packages are allowed to go through an interface only if the interface has
enough tokens in its bucket.
Make the clock-dependency of {{NetworkPrioritizerService}} explicit and
mockable, and mock it out in the {{NetworkPrioritizerServiceTests}} unit tests.
was:
The throughput of {{NetworkPrioritizerService}} depends on timing, as a certain
number of tokens are added to the "token bucket" every second, and packages are
allowed to go through an interface only if the interface has enough tokens in
its bucket.
Make the clock-dependency of {{NetworkPrioritizerService}} explicit and
mockable, and mock it out in the {{NetworkPrioritizerServiceTests}} unit tests.
> NetworkPrioritizerServiceTests are sensitive to timing
> ------------------------------------------------------
>
> Key: MINIFICPP-1432
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1432
> Project: Apache NiFi MiNiFi C++
> Issue Type: Bug
> Reporter: Ferenc Gerlits
> Assignee: Ferenc Gerlits
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The throughput of {{NetworkPrioritizerService}} depends on timing, as a
> certain number of tokens are added to the "token bucket" every millisecond,
> and packages are allowed to go through an interface only if the interface has
> enough tokens in its bucket.
> Make the clock-dependency of {{NetworkPrioritizerService}} explicit and
> mockable, and mock it out in the {{NetworkPrioritizerServiceTests}} unit
> tests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
