hunyadi-dev commented on a change in pull request #953:
URL: https://github.com/apache/nifi-minifi-cpp/pull/953#discussion_r542232128
##########
File path: extensions/http-curl/tests/C2JstackTest.cpp
##########
@@ -18,35 +18,46 @@
#undef NDEBUG
#include <string>
+#include <atomic>
#include "TestBase.h"
#include "HTTPIntegrationBase.h"
#include "HTTPHandlers.h"
#include "utils/IntegrationTestUtils.h"
class VerifyC2DescribeJstack : public VerifyC2Describe {
public:
+ explicit VerifyC2DescribeJstack(const std::atomic_bool&
acknowledgement_checked) : VerifyC2Describe(),
acknowledgement_checked_(acknowledgement_checked) {}
void runAssertions() override {
- using org::apache::nifi::minifi::utils::verifyLogLinePresenceInPollTime;
-
assert(verifyLogLinePresenceInPollTime(std::chrono::milliseconds(wait_time_),
"SchedulingAgent"));
+ // This check was previously only confirming the presence of log sinks.
+ // See: https://issues.apache.org/jira/browse/MINIFICPP-1421
Review comment:
It is probably no longer useful anymore, I thought this was going to be
a temporary fix, and people checking on it would find the attached jira useful,
but I decided to close the ticket after this PR is merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
