adamdebreceni commented on a change in pull request #958:
URL: https://github.com/apache/nifi-minifi-cpp/pull/958#discussion_r542465018
##########
File path: libminifi/include/controllers/NetworkPrioritizerService.h
##########
@@ -121,6 +126,7 @@ class NetworkPrioritizerService : public
core::controller::ControllerService, pu
bool verify_interfaces_;
private:
+ std::shared_ptr<utils::timeutils::Clock> clock_;
Review comment:
info(not ment to argue either for or against) : if we want to reference
a member of a `shared_ptr` pointee, and not accidentally mess up, we can share
the lifetime of the pointee while pointing to the member, so the "container" is
kept alive even if we are only using its member
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
