fgerlits commented on a change in pull request #966:
URL: https://github.com/apache/nifi-minifi-cpp/pull/966#discussion_r551273890
##########
File path: .github/workflows/ci.yml
##########
@@ -259,8 +249,7 @@ jobs:
ubuntu-16.04-shared-ccache-refs/heads/main-
- id: install_deps
run: |
- echo "::set-env name=CMAKE_BUILD_OPTIONS::-DENABLE_PCAP=TRUE"
sudo apt install -y ccache
- echo "::set-env name=PATH::/usr/lib/ccache:$PATH"
+ echo "PATH=/usr/lib/ccache:$PATH" >> $GITHUB_ENV
- id: build
run: ./bootstrap.sh -e -t && cd build && cmake -DUSE_SHARED_LIBS=ON
-DSTRICT_GSL_CHECKS=AUDIT .. && cmake --build . --parallel 4 && make test
ARGS="--timeout 300 -j4 --output-on-failure"
Review comment:
It looks like you manually removed the docker timeout change from this
cherry-picked commit. Why?
EDIT: never mind, that docker test does not exist on this branch, yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
