markap14 commented on pull request #4724: URL: https://github.com/apache/nifi/pull/4724#issuecomment-754092276
Verified that I'm able to switch between tabs in the processor config dialog and in the Controller Settings dialog. Based on the code changes, I think this should apply to all dialogs. Of note, in order to verify that, I had to click on one of the text boxes / inputs within the form and then press shift-tab to get to the tabs. Otherwise, just pressing tab jumped all over the place, as it selected elements in the background (like the search box) even though there was a dialog open. We should probably only allow tab to jump to elements in the dialog when a dialog is present. That said, I don't think it needs to be done in this PR/Jira. So I'm a +1. Will merge to main. Thanks @sardell ! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
