markap14 commented on pull request #4605: URL: https://github.com/apache/nifi/pull/4605#issuecomment-754162394
I would definitely favor parameters in this situation. In general, we want to avoid having to do lots of code updates to add support for variables for this property and that. But that said, adding support for variables here is also no problem. Since it's already done and it's a trivial change, and all code looks good, will go ahead and merge. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
