[
https://issues.apache.org/jira/browse/NIFI-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15548861#comment-15548861
]
ASF GitHub Bot commented on NIFI-1615:
--------------------------------------
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1103#discussion_r81982576
--- Diff: .github/PULL_REQUEST_TEMPLATE.md ---
@@ -0,0 +1,32 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+
+Thank you for submiting a contribution to Apache NiFi.
+
+In order to streamline the review of the contribution we ask you
+to ensure the follow steps have been taken:
+
+### For all changes:
+- [] Is there a JIRA ticket associated with this PR? Is is referenced
+ on the commit message?
+
+### For code changes:
+- [] Ensure that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder.
+- [] Please write or update unit tests to verify your changes.
+- [] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under ASF 2.0? Did you
update the LICENSE file?
+- [] If adding new Properties, have you added .displayName in addition to
.name for each of the new properties?
--- End diff --
May want to call out the differences between the two (display for display,
name for programmatic access)
> Create Pull Request template for GitHub
> ---------------------------------------
>
> Key: NIFI-1615
> URL: https://issues.apache.org/jira/browse/NIFI-1615
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Documentation & Website, Examples
> Reporter: Aldrin Piri
> Assignee: Andre
> Priority: Trivial
>
> GitHub has provided a way to generate templates that will get displayed when
> someone initiates a PR. Announcement here:
> https://github.com/blog/2111-issue-and-pull-request-templates
> This would cover the checklist items as seen in
> https://cwiki.apache.org/confluence/display/NIFI/Contributor+Guide and could
> aid in alleviating some of the iterations needed in advance of the review
> process.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
