turcsanyip commented on a change in pull request #4578:
URL: https://github.com/apache/nifi/pull/4578#discussion_r552055174
##########
File path:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/ConsumeMQTT.java
##########
@@ -82,6 +85,9 @@
@WritesAttribute(attribute=IS_DUPLICATE_ATTRIBUTE_KEY,
description="Whether or not this message might be a duplicate of one which has
already been received."),
@WritesAttribute(attribute=IS_RETAINED_ATTRIBUTE_KEY, description="Whether
or not this message was from a current publisher, or was \"retained\" by the
server as the last message published " +
"on the topic.")})
+@SystemResourceConsideration(resource = SystemResource.MEMORY, description =
"The 'Max Queue Size' specifies the maximum number of messages that can be hold
in memory by NiFi by a single "
+ + "instance of this processor. A high value for this property combined
with a high number of concurrent tasks for the processor could represent a lot
of data being stored in memory.")
Review comment:
I'm not sure if the number of concurrent tasks matters here because it
is the processor instance that holds the buffer queue.
Edit:
The processor annotated as `@TriggerSerially` so the concurrent tasks option
is not relevant at all I believe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
