arpadboda commented on a change in pull request #968:
URL: https://github.com/apache/nifi-minifi-cpp/pull/968#discussion_r552461565
##########
File path: docker/test/integration/test_s2s.py
##########
@@ -14,8 +14,6 @@
# limitations under the License.
from minifi import *
-from minifi.test import *
Review comment:
The main reason behind my feelings on import * is that it's impossible
to find the source of a given symbol when * is used across the code. So we
world has just become a better place. At least our code is a bit easier to
read. :)
##########
File path: docker/test/integration/test_s2s.py
##########
@@ -14,8 +14,6 @@
# limitations under the License.
from minifi import *
-from minifi.test import *
Review comment:
The main reason behind my feelings on import * is that it's impossible
to find the source of a given symbol when * is used across the code. So the
world has just become a better place. At least our code is a bit easier to
read. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
