adamdebreceni commented on a change in pull request #970:
URL: https://github.com/apache/nifi-minifi-cpp/pull/970#discussion_r552473202
##########
File path: extensions/aws/s3/S3WrapperBase.cpp
##########
@@ -68,13 +75,13 @@ void
S3WrapperBase::setCannedAcl(Aws::S3::Model::PutObjectRequest& request, cons
request.SetACL(CANNED_ACL_MAP.at(canned_acl));
}
-std::string S3WrapperBase::getExpiryDate(const std::string& expiration) {
+std::pair<std::string, std::string> S3WrapperBase::getExpirationPair(const
std::string& expiration) {
Review comment:
even though it is only used twice, we could create a `struct` (given how
both members of the pair are of the same type)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
