exceptionfactory opened a new pull request #4749:
URL: https://github.com/apache/nifi/pull/4749
#### Description of PR
NIFI-8121 Updates `ListenHTTP` with an additional configuration option for
the `Client Authentication` property to support automatic configuration of
requiring or requesting client certificates based on the presence or absence of
Trust Store properties in the configured `SSLContextService`.
NiFi versions 1.12.1 and prior do not have the `Client Authentication`
property and instead called `SslContextFactory.setNeedClientAuth(true)` when
the configured `SSLContextService` included Trust Store properties. The
introduction of the `Client Authentication` property in PR #4687 for NIFI-1930
removed this implicit behavior and did not provide backward compatibility for
configurations where `ListenHTTP` was configured for one-way TLS. The changes
included in this PR include a custom `ClientAuthentication` enum with a value
of `AUTO` that `ListenHTTP` uses as the default property value. This approach
will maintain backward compatibility during an upgrade and also allow explicit
configuration going forward.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically `main`)?
- [X] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [X] Have you written or updated unit tests to verify your changes?
- [X] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [X] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [X] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for
build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
