markap14 commented on a change in pull request #4730: URL: https://github.com/apache/nifi/pull/4730#discussion_r555186550
########## File path: nifi-external/nifi-kafka-connect/nifi-kafka-connector/src/main/java/org/apache/nifi/kafka/connect/StatelessNiFiSourceConnector.java ########## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.nifi.kafka.connect; + +import org.apache.kafka.common.config.ConfigDef; +import org.apache.kafka.connect.connector.Task; +import org.apache.kafka.connect.source.SourceConnector; +import org.apache.nifi.kafka.connect.validators.ConnectRegularExpressionValidator; + +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +public class StatelessNiFiSourceConnector extends SourceConnector { + static final String OUTPUT_PORT_NAME = "output.port"; + static final String TOPIC_NAME = "topic.name"; + + static final String TOPIC_NAME_ATTRIBUTE = "topic.name.attribute"; + static final String KEY_ATTRIBUTE = "key.attribute"; + static final String HEADER_REGEX = "header.attribute.regex"; + + private Map<String, String> properties; + + @Override + public void start(final Map<String, String> properties) { + this.properties = new HashMap<>(properties); + } + + @Override + public void reconfigure(final Map<String, String> properties) { + this.properties = new HashMap<>(this.properties); + } + + @Override + public Class<? extends Task> taskClass() { + return StatelessNiFiSourceTask.class; + } + + @Override + public List<Map<String, String>> taskConfigs(final int maxTasks) { + final List<Map<String, String>> configs = new ArrayList<>(); + for (int i=0; i < maxTasks; i++) { + configs.add(new HashMap<>(properties)); Review comment: In "NiFi proper" we have load-balanced connections that would allow the nodes to distribute the data between themselves to load-balance. We don't have that currently in Stateless NiFi. Not sure it would make sense to provide that in Stateless, given how it all works. I think for the moment, when interacting with a source that does not itself provide queuing/scaling semantics, we would just have to rely on the deployer making sure that the 'unit of work' that they deploy can be accomplished by a single task. There may be improvements that can be made to this in the future though. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
