mattyb149 commented on pull request #4739: URL: https://github.com/apache/nifi/pull/4739#issuecomment-758734159
+1 LGTM, ran contrib-check and tried on a live system. I did notice a typo on the `records.count` attribute, I will change that on merge to read `record.count` for consistency with other record-based processors. Also it's interesting that if the fields used in EL in the query aren't defined fields in the input record, it went through correctly (possibly because a `null` or empty string was inserted and no results were returned from the otherwise-valid query). Might want to look into this as a follow-on to see if there's a way to detect whether a field is unset or set to null. Thanks for the improvements! Merging to main ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
