jfrazee commented on a change in pull request #4753:
URL: https://github.com/apache/nifi/pull/4753#discussion_r556097342
##########
File path:
nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/NiFiProperties.java
##########
@@ -1540,6 +1540,12 @@ public boolean isZooKeeperTlsConfigurationPresent() {
&&
getProperty(NiFiProperties.ZOOKEEPER_SECURITY_TRUSTSTORE_PASSWD) != null;
}
+ public boolean isTlsConfigurationPresent() {
+ return
StringUtils.isNotBlank(getProperty(NiFiProperties.SECURITY_KEYSTORE))
+ && getProperty(NiFiProperties.SECURITY_KEYSTORE_PASSWD) != null
+ &&
StringUtils.isNotBlank(getProperty(NiFiProperties.SECURITY_TRUSTSTORE));
Review comment:
We made a stronger assumption in `isZooKeeperTlsConfigurationPresent()`
that truststorePasswd was present. I think what you're doing here, allowing
empty truststorePasswd, is correct but should we change
`isZooKeeperTlsConfigurationPresent()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
