fgerlits commented on a change in pull request #976:
URL: https://github.com/apache/nifi-minifi-cpp/pull/976#discussion_r559390975
##########
File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp
##########
@@ -134,8 +135,8 @@ core::Property ConsumeWindowsEventLog::OutputFormat(
core::PropertyBuilder::createProperty("Output Format")->
isRequired(true)->
withDefaultValue(Both)->
- withAllowableValues<std::string>({XML, Plaintext, Both})->
- withDescription("Set the output format type. In case \'Both\' is selected
the processor generates two flow files for every event captured")->
+ withAllowableValues<std::string>({XML, Plaintext, Both, JSONSimple,
JSONFlattened, JSONRaw})->
Review comment:
Even when we have list-type properties, we could have "XML,JSON" or
"JSON,Plaintext" as the output format property. A user would understand what
"JSON" is; they would not know (without asking us or the support team) what
JSONRaw, JSONSimple, JSONFlattened mean and how to choose between them.
I understand you have had this discussion already and have made a decision,
but I think it would be worth discussing it some more, as this decision causes
our code to be more complex and the user interface more difficult to use, both
meaning more work in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
