ChrisSamo632 commented on a change in pull request #4755:
URL: https://github.com/apache/nifi/pull/4755#discussion_r560466124
##########
File path:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/test/groovy/org/apache/nifi/elasticsearch/integration/ElasticSearch5ClientService_IT.groovy
##########
@@ -175,6 +177,41 @@ class ElasticSearch5ClientService_IT {
runner.assertValid()
}
+ @Test
+ void testNullSuppression() {
Review comment:
The integration tests run as part of the [Maven
build](https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/pom.xml#L193)
in the `nifi-elasticsearch-client-service` bundle, but need the correct
profiles actiating, for example:
* ES 7: `mvn -P integration-7,integration-tests clean install`
* ES 6: `mvn -P integration-6,integration-tests clean install`
* ES 5: `mvn -P integration-tests clean install`
These include the setup of indices and expected documents for the tests to
run (see the
[test/resources](https://github.com/apache/nifi/tree/main/nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/test/resources)
script files).
Running these locally with the code from this branch using JDK 11, I get
successful builds with the above commands.
I'm asuming the `_type` error you're getting above is because you're not
setting the `type_name` System property if you've trying to run these tests
without using the Maven build (you'd also need to setup the indices/documents
in the same way as the test scripts).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
