adamdebreceni commented on a change in pull request #955:
URL: https://github.com/apache/nifi-minifi-cpp/pull/955#discussion_r561038296
##########
File path: libminifi/test/unit/LoggerTests.cpp
##########
@@ -107,3 +110,71 @@ TEST_CASE("Test ShortenNames", "[ttl6]") {
LogTestController::getInstance(props)->reset();
LogTestController::getInstance().reset();
}
+
+using namespace minifi::io;
+
+std::string decompress(const std::shared_ptr<InputStream>& input) {
+ auto output = utils::make_unique<BufferStream>();
+ auto decompressor =
std::make_shared<ZlibDecompressStream>(gsl::make_not_null(output.get()));
+ minifi::internal::pipe(input, decompressor);
+ decompressor->close();
+ return std::string{reinterpret_cast<const char*>(output->getBuffer()),
output->size()};
+}
+
+TEST_CASE("Test Compression", "[ttl7]") {
+ auto& log_config = logging::LoggerConfiguration::getConfiguration();
+ auto properties = std::make_shared<logging::LoggerProperties>();
+ std::string className;
+ SECTION("Using root logger") {
+ className = "CompressionTestClassUsingRoot";
+ // by default the root logger is OFF
+ properties->set("logger.root", "INFO");
+ }
+ SECTION("Inherit compression sink") {
+ className = "CompressionTestClassInheriting";
+ properties->set("appender.null", "null");
+ properties->set("logger." + className, "INFO,null");
+ }
+ log_config.initialize(properties);
+ auto logger = log_config.getLogger(className);
+ logger->log_error("Hi there");
+ std::shared_ptr<InputStream>
compressed_log{logging::LoggerConfiguration::getCompressedLog(true)};
+ REQUIRE(compressed_log);
+ auto logs = decompress(compressed_log);
+ REQUIRE(logs.find("Hi there") != std::string::npos);
Review comment:
actually it turns out `logs == "Hi there"` so I changed it to that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
