[
https://issues.apache.org/jira/browse/NIFI-2836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15549835#comment-15549835
]
ASF GitHub Bot commented on NIFI-2836:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1109
NIFI-2836: Ensure that we wait until a request is completed before un…
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
…locking the lock for request replication
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-2836
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1109.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1109
----
commit 06d877cab9ee58267a532d91eb7574bb9a2660f9
Author: Mark Payne <[email protected]>
Date: 2016-10-05T20:19:55Z
NIFI-2836: Ensure that we wait until a request is completed before
unlocking the lock for request replication
----
> Cluster - Request Replication
> -----------------------------
>
> Key: NIFI-2836
> URL: https://issues.apache.org/jira/browse/NIFI-2836
> Project: Apache NiFi
> Issue Type: Sub-task
> Components: Core Framework
> Reporter: Matt Gilman
> Priority: Critical
> Fix For: 1.1.0
>
>
> When a request is replicated throughout the cluster, the cluster coordinator
> needs to ensure that request completes (including both parts of the two-phase
> commit if applicable) prior to replicating the next request.
> Looks like a write lock is obtained while submitted a background task. The
> actually work completes outside the locks scope.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
