[GitHub] [nifi] pvillard31 edited a comment on pull request #4768: NIFI-8155 - add banner text in page title

[GitBox]

pvillard31 edited a comment on pull request #4768:
URL: https://github.com/apache/nifi/pull/4768#issuecomment-764453581


   Thanks for looking into this @exceptionfactory. As far as I can tell the 
other places you mentioned are not "really" opening new windows and this not 
impacting the overall page title:
   
   <img width="869" alt="Screenshot 2021-01-21 at 11 53 43" 
src="https://user-images.githubusercontent.com/11541012/105320361-801ab280-5bdf-11eb-8fc0-969aac536b0c.png";>
   
   The only edge case I can think of is when looking at the content of a flow 
file: this will open a new tab/window and the title won't contain the info. But 
I believe this a very special edge case and I think this is best to leave it 
outside of the change.
   
   <img width="640" alt="Screenshot 2021-01-21 at 11 57 22" 
src="https://user-images.githubusercontent.com/11541012/105320689-e8699400-5bdf-11eb-84a7-dff5269efa25.png";>
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org