lordgamez commented on a change in pull request #975:
URL: https://github.com/apache/nifi-minifi-cpp/pull/975#discussion_r562047230
##########
File path: extensions/aws/s3/S3Wrapper.h
##########
@@ -31,11 +47,190 @@ namespace minifi {
namespace aws {
namespace s3 {
-class S3Wrapper : public S3WrapperBase {
+static const std::unordered_map<std::string, Aws::S3::Model::StorageClass>
STORAGE_CLASS_MAP {
+ {"Standard", Aws::S3::Model::StorageClass::STANDARD},
+ {"ReducedRedundancy", Aws::S3::Model::StorageClass::REDUCED_REDUNDANCY},
+ {"StandardIA", Aws::S3::Model::StorageClass::STANDARD_IA},
+ {"OnezoneIA", Aws::S3::Model::StorageClass::ONEZONE_IA},
+ {"IntelligentTiering", Aws::S3::Model::StorageClass::INTELLIGENT_TIERING},
+ {"Glacier", Aws::S3::Model::StorageClass::GLACIER},
+ {"DeepArchive", Aws::S3::Model::StorageClass::DEEP_ARCHIVE}
+};
+
+static const std::unordered_map<Aws::S3::Model::ObjectStorageClass,
std::string> OBJECT_STORAGE_CLASS_MAP {
+ {Aws::S3::Model::ObjectStorageClass::STANDARD, "Standard"},
+ {Aws::S3::Model::ObjectStorageClass::REDUCED_REDUNDANCY,
"ReducedRedundancy"},
+ {Aws::S3::Model::ObjectStorageClass::STANDARD_IA, "StandardIA"},
+ {Aws::S3::Model::ObjectStorageClass::ONEZONE_IA, "OnezoneIA"},
+ {Aws::S3::Model::ObjectStorageClass::INTELLIGENT_TIERING,
"IntelligentTiering"},
+ {Aws::S3::Model::ObjectStorageClass::GLACIER, "Glacier"},
+ {Aws::S3::Model::ObjectStorageClass::DEEP_ARCHIVE, "DeepArchive"}
+};
+
+static const std::unordered_map<Aws::S3::Model::ObjectVersionStorageClass,
std::string> VERSION_STORAGE_CLASS_MAP {
+ {Aws::S3::Model::ObjectVersionStorageClass::STANDARD, "Standard"}
+};
+
+static const std::unordered_map<std::string,
Aws::S3::Model::ServerSideEncryption> SERVER_SIDE_ENCRYPTION_MAP {
+ {"None", Aws::S3::Model::ServerSideEncryption::NOT_SET},
+ {"AES256", Aws::S3::Model::ServerSideEncryption::AES256},
+ {"aws_kms", Aws::S3::Model::ServerSideEncryption::aws_kms},
+};
+
+static const std::unordered_map<std::string, Aws::S3::Model::ObjectCannedACL>
CANNED_ACL_MAP {
+ {"BucketOwnerFullControl",
Aws::S3::Model::ObjectCannedACL::bucket_owner_full_control},
+ {"BucketOwnerRead", Aws::S3::Model::ObjectCannedACL::bucket_owner_read},
+ {"AuthenticatedRead", Aws::S3::Model::ObjectCannedACL::authenticated_read},
+ {"PublicReadWrite", Aws::S3::Model::ObjectCannedACL::public_read_write},
+ {"PublicRead", Aws::S3::Model::ObjectCannedACL::public_read},
+ {"Private", Aws::S3::Model::ObjectCannedACL::private_},
+ {"AwsExecRead", Aws::S3::Model::ObjectCannedACL::aws_exec_read},
+};
+
+struct Expiration {
+ std::string expiration_time;
+ std::string expiration_time_rule_id;
+};
+
+struct PutObjectResult {
+ std::string version;
+ std::string etag;
+ std::string expiration;
+ std::string ssealgorithm;
+};
+
+struct PutObjectRequestParameters {
+ std::string bucket;
+ std::string object_key;
+ std::string storage_class;
+ std::string server_side_encryption;
+ std::string content_type;
+ std::map<std::string, std::string> user_metadata_map;
+ std::string fullcontrol_user_list;
+ std::string read_permission_user_list;
+ std::string read_acl_user_list;
+ std::string write_acl_user_list;
+ std::string canned_acl;
+};
+
+struct GetObjectRequestParameters {
+ std::string bucket;
+ std::string object_key;
+ std::string version;
+ bool requester_pays = false;
+};
+
+struct HeadObjectResult {
+ std::string path;
+ std::string absolute_path;
+ std::string filename;
+ std::string mime_type;
+ std::string etag;
+ Expiration expiration;
+ std::string ssealgorithm;
+ std::string version;
+ std::map<std::string, std::string> user_metadata_map;
+
+ void setFilePaths(const std::string& key);
+};
+
+struct GetObjectResult : public HeadObjectResult {
+ int64_t write_size = 0;
+};
+
+struct ListRequestParameters {
+ std::string bucket;
+ std::string delimiter;
+ std::string prefix;
+ bool use_versions = false;
+ uint64_t min_object_age = 0;
+};
+
+struct ListedObjectAttributes {
+ std::string filename;
+ std::string etag;
+ bool is_latest = false;
+ int64_t last_modified = 0;
+ int length = 0;
+ std::string store_class;
+ std::string version;
Review comment:
I don't think in this case we would have a benefit for this field to be
optional as an empty version is not a valid value, so we cannot really
distinguish an empty version from an unset version, they should mean the same.
I think here it is easier just to check for an empty string if we want to check
if it has been set.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
