Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1108
@selim-namsi thanks for putting together. I was coding this processor but
happy to review it.
Few comments:
1. Your code is failing -Pcontrib-check. Can you please fix this?
2. Ideally I believe this processor should allow use to chose between
content replacement (replace the original log line with the json
representation) and adding attributes (what you already did). This should give
an idea of what I mean: https://github.com/apache/nifi/pull/785
3. Please don't hard-code the patterns, instead, let the user configure the
pattern files
4. The java-grok version has some bugs, you may want to upgrade it (this is
the reason I haven't submitted the code previously... :smiley: )
Thank you again, looking forward your modifications
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
