[
https://issues.apache.org/jira/browse/NIFI-2565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15550144#comment-15550144
]
ASF GitHub Bot commented on NIFI-2565:
--------------------------------------
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1108
@selim-namsi thanks for putting together. I was coding this processor but
happy to review it.
Few comments:
1. Your code is failing -Pcontrib-check. Can you please fix this?
2. Ideally I believe this processor should allow use to chose between
content replacement (replace the original log line with the json
representation) and adding attributes (what you already did). This should give
an idea of what I mean: https://github.com/apache/nifi/pull/785
3. Please don't hard-code the patterns, instead, let the user configure the
pattern files
4. The java-grok version has some bugs, you may want to upgrade it (this is
the reason I haven't submitted the code previously... :smiley: )
Thank you again, looking forward your modifications
> NiFi processor to parse logs using Grok patterns
> ------------------------------------------------
>
> Key: NIFI-2565
> URL: https://issues.apache.org/jira/browse/NIFI-2565
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Andre
> Fix For: 1.1.0
>
>
> Following up on Ryan Ward to create a Grok capable parser
> https://mail-archives.apache.org/mod_mbox/nifi-dev/201606.mbox/%3CCADD=rnPa8nHkJbeM280=PTQ=wurtwhstm5u+7btoo9pcym2...@mail.gmail.com%3E
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
