Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1093#discussion_r82104883
--- Diff:
nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java ---
@@ -581,30 +585,31 @@ private Status getStatus(final Logger logger) {
return new Status(port, pid, pingSuccess, alive);
}
- public void status() throws IOException {
+ public int status() throws IOException {
final Logger logger = cmdLogger;
final Status status = getStatus(logger);
if (status.isRespondingToPing()) {
logger.info("Apache NiFi is currently running, listening to
Bootstrap on port {}, PID={}",
new Object[]{status.getPort(), status.getPid() == null
? "unknown" : status.getPid()});
- return;
+ return 0;
}
if (status.isProcessRunning()) {
logger.info("Apache NiFi is running at PID {} but is not
responding to ping requests", status.getPid());
- return;
+ return 0;
--- End diff --
Should this 0? I would imagine returning 4 _"program or service status is
unknown"_ would make more sense?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
