lordgamez commented on a change in pull request #974:
URL: https://github.com/apache/nifi-minifi-cpp/pull/974#discussion_r563790242
##########
File path: libminifi/include/core/state/UpdateController.h
##########
@@ -148,7 +148,16 @@ class UpdateRunner : public utils::AfterExecute<Update> {
std::chrono::milliseconds delay_;
};
-class StateController {
+class PausableStateController {
+ public:
+ virtual ~PausableStateController() = default;
+
+ virtual int16_t pause() = 0;
+
+ virtual int16_t resume() = 0;
+};
Review comment:
I updated the name of the interface in
[11cca31](https://github.com/apache/nifi-minifi-cpp/pull/974/commits/11cca310b1dd516fbdaf0e1264fbe6f0c552803e).
I would stay with this implementation now instead of a Pausable concept, it
seems more simple and explicit for me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
