exceptionfactory commented on pull request #4779:
URL: https://github.com/apache/nifi/pull/4779#issuecomment-766910732


   > looked through each of the dep updates. Since they are generally updating 
only dependency management it is probably fair game to elevate the specific 
declaration to the top level pom's dependency mgmt section. The others which 
are updated for dependency (not dependency management are fine since they 
simply remove the version declaration (thus it comes from parent poms). So I 
believe this will be easier to maintain without changing the actual behavior.
   > 
   > That said hopefully this tackles the github actions issue which has 
emerged. Will watch this build.
   
   @joewitt Thanks for reviewing the changes.  As mentioned in the PR 
description, uses of Bouncy Castle in classes within `nifi-security-utils` 
impact the entire system, so it seems to be best to elevate version management 
to the root Maven configuration.
   
   The initial GitHub CI run failed with a couple assertion errors, as opposed 
to the SSL handshake exceptions previously observed, so I pushed an update to 
increase the timeouts in the two failing HTTP tests.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to